aratno commented on code in PR #4118:
URL: https://github.com/apache/cassandra/pull/4118#discussion_r2078543255
##########
src/java/org/apache/cassandra/io/sstable/metadata/MetadataSerializer.java:
##########
@@ -123,17 +124,10 @@ public Map<MetadataType, MetadataComponent>
deserialize(Descriptor descriptor, E
logger.trace("Load metadata for {}", descriptor);
File statsFile = descriptor.fileFor(Components.STATS);
if (!statsFile.exists())
+ throw new NoSuchFileException("Stats component of sstable " +
descriptor + " is missing");
Review Comment:
Discussed here:
https://github.com/apache/cassandra/pull/4118#discussion_r2067067477
When Component.STATS was introduced in CASSANDRA-6356, a default was
provided in case the file was missing, to support migration from earlier
versions. This has been present since BigFormat `-ka` which is below the
minimum now-supported SSTable version `-ma`:
https://github.com/apache/cassandra/blob/f340514bbe1a8b88c5df3a3949bfc1fd937e576b/src/java/org/apache/cassandra/io/sstable/format/big/BigFormat.java#L119
How would you assess the risk of this change, assuming all relevant tests
pass? Conversation on devlist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
