gowa commented on code in PR #4166:
URL: https://github.com/apache/cassandra/pull/4166#discussion_r2116287617
##########
bin/cassandra:
##########
@@ -188,6 +188,10 @@ launch_service()
cassandra_parms="$cassandra_parms -Dcassandra-pidfile=$pidpath"
fi
+ if [ "x$call_clean_heap_dump_files" != "x" ]; then
+ clean_heap_dump_files || true
Review Comment:
if I got it right, cassandra-env.sh maybe always be sources, meaning the
function 'clean_heap_dump_files' can potentially be not declared (which I in
fact attempted to resolve by `call_clean_heap_dump_files` as well), and the
logic itself does not look to be super important to fail the whole startup
sequence should anything goes wrong with it.
Can remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
