gowa commented on code in PR #4166:
URL: https://github.com/apache/cassandra/pull/4166#discussion_r2116620276
##########
bin/cassandra:
##########
@@ -247,6 +251,8 @@ while true; do
;;
-H)
properties="$properties -XX:HeapDumpPath=$2"
+ # disable automatic heap dump files management as HeapDumpPath was
overridden
+ call_clean_heap_dump_files=
Review Comment:
replaced by `CASSANDRA_HEAPDUMP_CLEAN=0`
##########
conf/cassandra-env.sh:
##########
@@ -199,6 +199,45 @@ if [ "x$CASSANDRA_HEAPDUMP_DIR" = "x" ]; then
fi
JVM_OPTS="$JVM_OPTS -XX:HeapDumpPath=$CASSANDRA_HEAPDUMP_DIR/cassandra-`date
+%s`-pid$$.hprof"
+# by default, enable cassandra heapdump files clean up, keeping 2 latest files
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
