gowa commented on code in PR #4166: URL: https://github.com/apache/cassandra/pull/4166#discussion_r2116624407
########## conf/cassandra-env.sh: ########## @@ -199,6 +199,45 @@ if [ "x$CASSANDRA_HEAPDUMP_DIR" = "x" ]; then fi JVM_OPTS="$JVM_OPTS -XX:HeapDumpPath=$CASSANDRA_HEAPDUMP_DIR/cassandra-`date +%s`-pid$$.hprof" +# by default, enable cassandra heapdump files clean up, keeping 2 latest files +# and 1 oldest heap dump file (this may help identify the earliest OOM issue) +if [ "x$CASSANDRA_HEAPDUMP_CLEAN" = "x" ]; then Review Comment: was thinking of sanity check for the values... the function will fail with some error if these parameters are not integers. for any integers it's either no op or removes some files, which is fine. even negative values have some meaning - 'remove everything'. left intact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
