gowa commented on code in PR #4166: URL: https://github.com/apache/cassandra/pull/4166#discussion_r2116619708
########## bin/cassandra: ########## @@ -188,6 +188,10 @@ launch_service() cassandra_parms="$cassandra_parms -Dcassandra-pidfile=$pidpath" fi + if [ "x$call_clean_heap_dump_files" != "x" ]; then + clean_heap_dump_files || true Review Comment: agree. replaced by clean_heap_dump_files_defined for clarity. it's now only defined in cassandra-env.sh. in cassandra.sh it's now ``` if [ "x$clean_heap_dump_files_defined" = "x1" ]; then clean_heap_dump_files fi ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org