szymon-miezal commented on PR #4189: URL: https://github.com/apache/cassandra/pull/4189#issuecomment-2929676688
The fix makes sense to me, I have allowed myself to add a small test that verifies and documents the case when max segment size is smaller than page size - https://github.com/szymon-miezal/cassandra/commit/b444c66413a99d8f5ed9b94d7deaee191d3e083c, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
