aweisberg commented on code in PR #4189: URL: https://github.com/apache/cassandra/pull/4189#discussion_r2121883340
########## test/unit/org/apache/cassandra/io/sstable/SSTableReaderTest.java: ########## @@ -1242,6 +1242,7 @@ private <R extends SSTableReader & IndexSummarySupport<R>> void testIndexSummary } R reopen = (R) SSTableReader.open(store, sstable.descriptor); assert reopen.getIndexSummary().getSamplingLevel() == sstable.getIndexSummary().getSamplingLevel() + 1; + reopen.selfRef().release(); Review Comment: Is this to deal with the leaks? It needs to be in try/finally around everything since the ref is acquired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org