aweisberg commented on code in PR #4189:
URL: https://github.com/apache/cassandra/pull/4189#discussion_r2122154089
##########
test/unit/org/apache/cassandra/io/sstable/SSTableReaderTest.java:
##########
@@ -143,6 +150,23 @@ public static void defineSchema() throws Exception
CompactionManager.instance.disableAutoCompaction();
}
+ @After
+ public void teardown()
+ {
+ for (Ref<?> ref : refsToRelease)
+ {
+ try
+ {
+ ref.release();
+ }
+ catch (Exception exc)
+ {
+ LOGGER.error("Error releasing ref during teardown: {}", ref,
exc);
Review Comment:
This should fail the test not be caught. You can do the throwable merge
pattern if you want to release all of them before failing the test and then
throw the first one with the rest suppressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
