aweisberg commented on code in PR #4189:
URL: https://github.com/apache/cassandra/pull/4189#discussion_r2122156276
##########
test/unit/org/apache/cassandra/io/sstable/SSTableReaderTest.java:
##########
@@ -1435,4 +1470,9 @@ private ColumnFamilyStore discardSSTables(String ks,
String cf)
cfs.discardSSTables(System.currentTimeMillis());
return cfs;
}
+
+ private void trackReleaseableRef(Ref<?> ref)
Review Comment:
Slightly pedantic, but return the ref and then invoke track releasable ref
around the thing that actually allocates the ref so it never "escapes".
Optional though since the existing thing also works fines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
