jameshartig commented on PR #1855: URL: https://github.com/apache/cassandra-gocql-driver/pull/1855#issuecomment-2938475458
> Are you completely against adding the protocol version as a parameter to the Marshal/Unmarshal functions of TypeInfo? If the concern is how intrusive the change might be for users then we could try and explore ways to make it less intrusive but the core principal of having access to the protocol version being used while marshalling and unmarshalling is quite important in my view I split out the `TypeInfo` from the `CQLType` so that if the protocol is needed it can be set on the `TypeInfo` before it's returned from the `CQLType`. It didn't feel necessary to add it to the `Marshal`/`Unmarshal` methods because internally only the `CollectionType` needs the protocol and everything else doesn't, so why are we forcing all of them to ignore a new parameter when only 1 type needs it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
