joao-r-reis commented on PR #1855: URL: https://github.com/apache/cassandra-gocql-driver/pull/1855#issuecomment-2940037648
I can't find the thread discussing the error vs panic but I got a notification of it so I'll reply here. > I'm in favor of panic only because these should happen at init and there's nothing else to do but panic and the stack trace will probably be helpful for anyone calling this. > What if we changed it to MustRegisterType? Then we could add a error-returning version later if there's an ask for it? I think changing it to `MustRegisterType` is a good compromise. In my mind I can see some users wanting to handle that error because they don't want their app to crash in any circumstance but I'm not sure so waiting to see if there is demand for it is a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
