joao-r-reis commented on PR #1855: URL: https://github.com/apache/cassandra-gocql-driver/pull/1855#issuecomment-2939978396
> It didn't feel necessary to add it to the Marshal/Unmarshal methods because internally only the CollectionType needs the protocol and everything else doesn't, so why are we forcing all of them to ignore a new parameter when only 1 type needs it? I was mostly thinking about future protocol versions that might change the format of existing types similar to what was done to collections in v3 but IIUC we will be able to do it via `TypeInfo` if it is needed correct? If this is the case then I'm ok with it. Also there's #1890 and I'm probably going to merge it after this one which will remove the need to check the protocol version even for collections -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
