jameshartig commented on code in PR #1855:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1855#discussion_r2129010583
##########
helpers.go:
##########
@@ -542,19 +154,41 @@ func (iter *Iter) MapScan(m map[string]interface{}) bool {
return false
}
- rowData, err := iter.RowData()
- if err != nil {
- return false
- }
-
- for i, col := range rowData.Columns {
- if dest, ok := m[col]; ok {
- rowData.Values[i] = dest
+ cols := iter.Columns()
+ columnNames := make([]string, 0, len(cols))
+ values := make([]interface{}, 0, len(cols))
+ for _, column := range iter.Columns() {
Review Comment:
This was using `RowData` to get the default values for every single column
and then replacing them, so if you passed a map with all existing columns
defined then the `RowData` call was completely pointless. I also had ambitions
of getting rid of `RowData`. I did end up getting rid of `rowMap` though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
