dcapwell commented on code in PR #4202:
URL: https://github.com/apache/cassandra/pull/4202#discussion_r2155070634
##########
src/java/org/apache/cassandra/utils/ImmutableUniqueList.java:
##########
@@ -107,6 +119,23 @@ public int size()
return values.length;
}
+ @Override
+ public boolean equals(Object o)
Review Comment:
also, this respects the fact that a set.equals(ImmutableUniqueList) would
return `true`, so this set should also return `true`; forcing order means that
we loose that property
```java
a.equals(b) == b.equals(a)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
