dcapwell commented on code in PR #4202: URL: https://github.com/apache/cassandra/pull/4202#discussion_r2155068178
########## src/java/org/apache/cassandra/utils/ImmutableUniqueList.java: ########## @@ -107,6 +119,23 @@ public int size() return values.length; } + @Override + public boolean equals(Object o) Review Comment: ```java jshell> var order = new LinkedHashSet<Integer>() order ==> [] jshell> var unordered = new HashSet<Integer>() unordered ==> [] jshell> order.add(4); order.add(3); $3 ==> true $4 ==> true jshell> unordered.add(3); unordered.add(4); $5 ==> true $6 ==> true jshell> order.equals(unordered) $7 ==> true jshell> unordered.equals(or order jshell> unordered.equals(order); $8 ==> true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org