dcapwell commented on code in PR #4202: URL: https://github.com/apache/cassandra/pull/4202#discussion_r2155085497
########## test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java: ########## @@ -1539,9 +1539,10 @@ private List<PrimaryKey> findByPartitionEq(LookupContext ctx) private Clustering<ByteBuffer> key(Map<Symbol, Expression> values, ImmutableUniqueList<Symbol> columns) { + if (columns.isEmpty()) return Clustering.EMPTY; // same as keys, but only one possible value can happen List<Clustering<ByteBuffer>> keys = keys(Maps.transformValues(values, Collections::singletonList), columns); - Preconditions.checkState(keys.size() == 1, "Expected 1 key, but found %d", keys.size()); + Preconditions.checkState(keys.size() == 1, "Expected 1 key, but found %s", keys.size()); Review Comment: guava doesn't use `String.format` and uses `%s` for all arguments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org