dcapwell commented on code in PR #4202: URL: https://github.com/apache/cassandra/pull/4202#discussion_r2155084596
########## test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java: ########## @@ -1539,9 +1539,10 @@ private List<PrimaryKey> findByPartitionEq(LookupContext ctx) private Clustering<ByteBuffer> key(Map<Symbol, Expression> values, ImmutableUniqueList<Symbol> columns) { + if (columns.isEmpty()) return Clustering.EMPTY; Review Comment: bug reported by @sunil9977 ; since i was already here quick to patch. The bug is that not every table has clustering columns so we should return empty. This wasn't noticed as CI doesn't run harry unit tests =( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org