yifan-c commented on code in PR #227: URL: https://github.com/apache/cassandra-sidecar/pull/227#discussion_r2157351756
########## server/src/main/java/org/apache/cassandra/sidecar/modules/UtilitiesModule.java: ########## @@ -53,7 +53,7 @@ TimeProvider timeProvider() @Singleton DnsResolver dnsResolver() { - return DnsResolver.DEFAULT; + return DnsResolver.DnsResolverEnum.DEFAULT; Review Comment: Nit: how about moving the enum declaration into its own Java file? So that we can have a simpler statement, without the 'DnsResolver.' portion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org