frankgh commented on code in PR #227:
URL: https://github.com/apache/cassandra-sidecar/pull/227#discussion_r2157387025
##########
conf/sidecar.yaml:
##########
@@ -158,6 +158,11 @@ sidecar:
# The minimum value allowed for the cluster lease claim process task
implementation is 30 seconds
execute_interval: 100s
+ # DnsResolver to use
(org.apache.cassandra.sidecar.common.server.dns.DnsResolver). Currently
supported
+ # values are 'default' and 'resolveToIp'. Default will resolve hostnames
to addresses and addresses to
+ # hostnames whereas resolveToIp will only resolve hostnames to addresses.
+ dnsResolver: default
Review Comment:
can we use snake case here to be consistent with the rest of the yaml?
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/ServiceConfigurationImpl.java:
##########
@@ -149,6 +151,9 @@ public class ServiceConfigurationImpl implements
ServiceConfiguration
@JsonProperty(value = COORDINATION)
protected final CoordinationConfiguration coordinationConfiguration;
+ @JsonProperty(value = DNS_RESOLVER_PROPERTY)
+ protected final DnsResolver.DnsResolverEnum dnsResolver;
Review Comment:
The type here should also be interface `DnsResolver`
##########
integration-framework/src/test/java/org/apache/cassandra/sidecar/testing/ResolveToIpDnsResolverTest.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.sidecar.testing;
+
+import org.apache.cassandra.sidecar.common.server.dns.DnsResolver;
+import org.junit.jupiter.api.Test;
+
+import java.net.UnknownHostException;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class ResolveToIpDnsResolverTest {
Review Comment:
This class might need reformatting
```suggestion
public class ResolveToIpDnsResolverTest
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
