smiklosovic commented on code in PR #227: URL: https://github.com/apache/cassandra-sidecar/pull/227#discussion_r2157502632
########## server-common/src/main/java/org/apache/cassandra/sidecar/common/server/dns/DnsResolvers.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.common.server.dns; + +import java.net.InetAddress; +import java.net.UnknownHostException; + +import com.fasterxml.jackson.annotation.JsonProperty; + +/** + * Determines which DnsResolver to use. Currently supported implementations are + * default and resolve_to_ip. The former will resolve hostname to address and + * address to hostname whereas the latter will only resolve hostname to address. + */ +public enum DnsResolvers implements DnsResolver +{ + /** + * Default implementation of the {@link DnsResolver} that uses the JDK's + * underlying DNS resolution mechanism + */ + @JsonProperty("default") + DEFAULT("default") Review Comment: do we still need this name? is it still necessary? Is not this covered by JsonProperty already? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
