smiklosovic commented on code in PR #227:
URL: https://github.com/apache/cassandra-sidecar/pull/227#discussion_r2157488745


##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/SidecarConfigurationImpl.java:
##########
@@ -384,6 +384,10 @@ private static SimpleModule resolveYamlTypeMappings() 
throws IOException
                      module.addAbstractTypeMapping(configurationInterface, 
clazz);
                  });
 
+        // Manually add type mapping for DnsResolver
+        
module.addAbstractTypeMapping(org.apache.cassandra.sidecar.common.server.dns.DnsResolver.class,

Review Comment:
   why so long? we can just import each, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to