belliottsmith commented on code in PR #219:
URL: https://github.com/apache/cassandra-accord/pull/219#discussion_r2227872848
##########
accord-core/src/main/java/accord/coordinate/AbstractCoordinatePreAccept.java:
##########
@@ -114,16 +114,6 @@ void setFailure(Throwable failure)
// we may already be complete, as we may receive a failure from a
later phase; but it's fine to redundantly mark done
isDone = true;
callback.accept(null, failure);
- if (failure instanceof CoordinationFailed)
Review Comment:
Yes, we had both duplication and inconsistency. I wanted to pick one of the
two approaches, and the most consistent and simplest to reason about was to
keep the handler of the request as responsible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
