belliottsmith commented on code in PR #219:
URL: https://github.com/apache/cassandra-accord/pull/219#discussion_r2227882103
##########
accord-core/src/main/java/accord/coordinate/Propose.java:
##########
@@ -197,9 +197,10 @@ void onAccepted()
// In this case either id' needs to wait (which requires potentially
more states like the alternative medium path)
// Or we must pick it up as an Unstable dependency here.
Deps newDeps = mergeNewDeps();
- Deps stableDeps = mergeDeps(newDeps);
- if (kind == Kind.MEDIUM) adapter().execute(node, executor,
acceptTracker.topologies(), route, ballot, MEDIUM, CoordinationFlags.none(),
txnId, txn, executeAt, stableDeps, newDeps, callback);
- else adapter().stabilise(node, executor, acceptTracker.topologies(),
route, ballot, txnId, txn, executeAt, stableDeps, callback);
+ Deps deps = mergeDeps(newDeps);
+ node.agent().coordinatorEvents().onAccepted(txnId, ballot, deps, kind
== Kind.MEDIUM);
Review Comment:
We have enough kind variables, but I can introduce an IsStable enum with
IS_STABLE and NOT_STABLE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
