belliottsmith commented on code in PR #219:
URL: https://github.com/apache/cassandra-accord/pull/219#discussion_r2228110852
##########
accord-core/src/main/java/accord/coordinate/CoordinateTransaction.java:
##########
@@ -128,8 +129,8 @@ void onPreAccepted(Topologies topologies, Timestamp
executeAt, SortedListMap<Nod
// note: we merge all Deps regardless of witnessedAt. While we
only need fast path votes,
// we must include Deps from fast path votes from earlier
epochs that may have witnessed later transactions
// TODO (desired): we might mask some bugs by merging more
responses than we strictly need, so optimise this to optionally merge minimal
deps
+ node.agent().coordinatorEvents().onPreAccepted(txnId, deps,
true);
Review Comment:
I changed my mind, and just removed it entirely. It makes more sense to just
do this in `onExecuting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
