belliottsmith commented on code in PR #219: URL: https://github.com/apache/cassandra-accord/pull/219#discussion_r2228112629
########## accord-core/src/main/java/accord/local/Commands.java: ########## @@ -286,8 +297,9 @@ public static AcceptOutcome accept(SafeCommandStore safeStore, SafeCommand safeC PartialDeps partialDeps = prepareDeps(validated, participants, command, deps); participants = prepareParticipants(validated, participants, command); - safeCommand.accept(safeStore, newSaveStatus, participants, ballot, executeAt, partialTxn, partialDeps, ballot); + Command accepted = safeCommand.accept(safeStore, newSaveStatus, participants, ballot, executeAt, partialTxn, partialDeps, ballot); safeStore.notifyListeners(safeCommand, command); + safeStore.agent().localEvents().onAccepted(safeStore, accepted); Review Comment: Sure. I think it makes sense either way, so happy to do it first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org