dcapwell commented on code in PR #4231:
URL: https://github.com/apache/cassandra/pull/4231#discussion_r2258325927


##########
src/java/org/apache/cassandra/config/YamlConfigurationLoader.java:
##########
@@ -72,6 +74,9 @@ public class YamlConfigurationLoader implements 
ConfigurationLoader
      * system properties do not conflict with other system properties; the 
name "settings" matches system_views.settings.
      */
     static final String SYSTEM_PROPERTY_PREFIX = "cassandra.settings.";
+    static final String ENVIRONMENT_VARIABLE_PREFIX = "CASS_";

Review Comment:
   `src/java/org/apache/cassandra/config/CassandraRelevantEnv.java`
   
   ```
       CASSANDRA_SKIP_SYNC("CASSANDRA_SKIP_SYNC"),
       /** By default, the standard Cassandra CLI layout is used for backward 
compatibility, however,
        * the new Picocli layout can be enabled by setting this property to the 
{@code "picocli"}. */
       CASSANDRA_CLI_LAYOUT("CASSANDRA_CLI_LAYOUT"),
   
   ```
   
   so the current pattern is `CASSANDRA_` at least, so I support that prefix.  
Agree `CASSANDRA_SETTINGS_` is more consistent with props



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to