pauloricardomg commented on code in PR #4231:
URL: https://github.com/apache/cassandra/pull/4231#discussion_r2264109798
##########
src/java/org/apache/cassandra/config/YamlConfigurationLoader.java:
##########
@@ -72,6 +74,9 @@ public class YamlConfigurationLoader implements
ConfigurationLoader
* system properties do not conflict with other system properties; the
name "settings" matches system_views.settings.
*/
static final String SYSTEM_PROPERTY_PREFIX = "cassandra.settings.";
+ static final String ENVIRONMENT_VARIABLE_PREFIX = "CASS_";
Review Comment:
The idea was to save some characters indeed since the argve space is limited
(~2MB I think) but probably overoptimization - check out this fun story:
https://social.treehouse.systems/@ska/114908845598719689 :D
I prefer to avoid `CASSANDRA_` prefix alone since this may clash with custom
variables. I updated it to `CASSANDRA_OPT_` but happy to use
`CASSANDRA_SETTING_` or `CASSANDRA_SETTINGS_` to make it consistent if you
prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
