dcapwell commented on code in PR #4231:
URL: https://github.com/apache/cassandra/pull/4231#discussion_r2271410466
##########
src/java/org/apache/cassandra/config/CassandraRelevantEnv.java:
##########
@@ -61,6 +66,11 @@ public boolean getBoolean()
return Boolean.parseBoolean(System.getenv(key));
}
+ public boolean getBooleanOrDefault(Boolean defaultValue)
Review Comment:
nit:
```suggestion
public boolean getBooleanOrDefault(boolean defaultValue)
```
this input allows `null` but will hit a NPE when returning; so good to block
`Boolean` in favor of `boolean`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
