smiklosovic commented on code in PR #4231:
URL: https://github.com/apache/cassandra/pull/4231#discussion_r2272492427
##########
src/java/org/apache/cassandra/config/YamlConfigurationLoader.java:
##########
@@ -163,21 +184,64 @@ private static void maybeAddSystemProperties(Object obj)
if
(CassandraRelevantProperties.CONFIG_ALLOW_SYSTEM_PROPERTIES.getBoolean())
{
java.util.Properties props = System.getProperties();
- Map<String, String> map = new HashMap<>();
- for (String name : props.stringPropertyNames())
+ Map<String, Object> map = new HashMap<>();
+ for (String originalKey : props.stringPropertyNames())
{
- if (name.startsWith(SYSTEM_PROPERTY_PREFIX))
+ if (originalKey.startsWith(SYSTEM_PROPERTY_PREFIX))
{
- String value = props.getProperty(name);
- if (value != null)
- map.put(name.replace(SYSTEM_PROPERTY_PREFIX, ""),
value);
+ String value = props.getProperty(originalKey);
+ String configKey =
originalKey.replace(SYSTEM_PROPERTY_PREFIX, "");
+ if (OVERRIDABLE_CONFIG_NAMES.contains(configKey) && value
!= null && !map.containsKey(configKey))
Review Comment:
fixed in my branch here:
https://github.com/smiklosovic/cassandra/commit/d5740c46c638664f4d4e3cc9c6188aa9b845d278
cc @pauloricardomg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
