aweisberg commented on code in PR #4508:
URL: https://github.com/apache/cassandra/pull/4508#discussion_r2611520381


##########
src/java/org/apache/cassandra/db/Keyspace.java:
##########
@@ -403,7 +404,7 @@ public void initCf(TableMetadata metadata, boolean 
loadSSTables)
 
     public Future<?> applyFuture(Mutation mutation, boolean writeCommitLog, 
boolean updateIndexes)
     {
-        return getMetadata().useMutationTracking()
+        return MigrationRouter.isFullyTracked(mutation)

Review Comment:
   OK, so the splitting is supposed to happen at the coordinator, but that is 
racy since things could change when we get here? Then we surface an error to 
the client?
   
   StorageProxy.mutateWithTracking is also an unused method now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to