aweisberg commented on code in PR #4508:
URL: https://github.com/apache/cassandra/pull/4508#discussion_r2624668078
##########
src/java/org/apache/cassandra/hints/Hint.java:
##########
@@ -99,11 +101,16 @@ Future<?> applyFuture()
{
if (isLive())
{
+ ClusterMetadata cm = ClusterMetadata.current();
// filter out partition update for tables that have been truncated
since hint's creation
Mutation filtered = mutation;
for (TableId id : mutation.getTableIds())
+ {
+ if (MigrationRouter.shouldUseTrackedForWrites(cm,
mutation.getKeyspaceName(), id, mutation.key().getToken()))
Review Comment:
Does this actually skip the mutation? I think it just skips checking for
truncation by continuing the loop. It would need to filter to actually remove
the table from the mutation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
