aweisberg commented on code in PR #4508:
URL: https://github.com/apache/cassandra/pull/4508#discussion_r2624683239


##########
src/java/org/apache/cassandra/hints/HintsDispatcher.java:
##########
@@ -417,7 +417,7 @@ private SplitHint 
splitHintIntoAccordAndNormal(ClusterMetadata cm, Hint hint)
     {
         SplitMutation<Mutation> splitMutation = 
ConsensusMigrationMutationHelper.instance().splitMutation(hint.mutation, cm);
         if (splitMutation.trackedMutation != null)

Review Comment:
   How does this handle the case where there ends up being no nomral or accord 
part of the mutation? Won't the callback in the caller never end up firing and 
it will hang?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to