omniCoder77 commented on code in PR #4596:
URL: https://github.com/apache/cassandra/pull/4596#discussion_r2752551698
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -5483,6 +5483,19 @@ public static void setUseStatementsEnabled(boolean
enabled)
}
}
+ public static boolean getMispreparedStatementsEnabled()
+ {
+ return conf.misprepared_statements_enabled;
+ }
+
+ public static void setMispreparedStatementsEnabled(boolean enabled)
Review Comment:
Logging might be necessary when changing this value for auditing trail for
live changes.
Using if might be necessary for idempotency.
In k8s, sidecars might trigger `setMispreparedStatementsEnabled` 10 time,
the log will be flooded by "Setting misprepare_statements_enabled to
true/false".
However it's a very unlikely scenario where a sidecar will change this
property in production, only changes may be in development phase, should I
remove if + logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
