smiklosovic commented on code in PR #4596:
URL: https://github.com/apache/cassandra/pull/4596#discussion_r2752213260
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -495,6 +506,11 @@ public static Prepared parseAndPrepare(String query,
ClientState clientState, bo
CQLStatement statement = raw.prepare(clientState);
statement.validate(clientState);
+ if (!isInternal && !clientState.isInternal)
Review Comment:
I am not sure if we should add the logic, conceptually, into this class. If
you check close enough then you see that there is "statement.validate()" just
above. If you check what, for example, SelectStatement.validate() is doing, it
contains guardrails too.
We would just enrich validate methods for each respective statement kind you
want to check here instead of having arbitrary logic in this class directly. I
think that is way cleaner approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
