omniCoder77 commented on code in PR #4596:
URL: https://github.com/apache/cassandra/pull/4596#discussion_r2752562202
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -130,6 +135,12 @@ public class QueryProcessor implements QueryHandler
// counters. Callers of processStatement are responsible for correctly
notifying metrics
public static final CQLMetrics metrics = new CQLMetrics();
+
+ private static final String msg = "Performance Tip: This query contains
literal values in the WHERE clause. " +
Review Comment:
You're right, msg was way too generic. I’ve updated the variable name as per
your suggestion.
Quick question on the naming: since this is technically a warning rather
than a hard error, would you prefer `MISPREPARED_STATEMENT_WARN_MESSAGE`, or
should I stick with your suggestion of `MISPREPARED_STATEMENT_MESSAGE` to keep
it concise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
