smiklosovic commented on code in PR #4599:
URL: https://github.com/apache/cassandra/pull/4599#discussion_r2757555832
##########
src/java/org/apache/cassandra/db/compression/ICompressionDictionaryTrainer.java:
##########
@@ -159,6 +144,6 @@ enum TrainingStatus
SAMPLING,
Review Comment:
I am not completely sure about this staying here. We are technically not
sampling anymore. SAMPLING is the state after we do "start" and we depend on
this state when we go to train. It would be probably better to replace it with
"started".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
