yifan-c commented on code in PR #4599:
URL: https://github.com/apache/cassandra/pull/4599#discussion_r2762575277
##########
src/java/org/apache/cassandra/db/compression/ICompressionDictionaryTrainer.java:
##########
@@ -159,6 +144,6 @@ enum TrainingStatus
SAMPLING,
Review Comment:
I think the "SAMPLING" status still make sense. The current and only
approach to collect training data is to perform random _sampling_ on the the
on-disk sstables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
