smiklosovic commented on code in PR #4599:
URL: https://github.com/apache/cassandra/pull/4599#discussion_r2757563653
##########
src/java/org/apache/cassandra/db/compression/ICompressionDictionaryTrainer.java:
##########
@@ -159,6 +144,6 @@ enum TrainingStatus
SAMPLING,
Review Comment:
It would be also maybe better if we called "start" method of
ICompressionDictionaryTrainer like "init" instead of "start". We have not
started anything and we are not sampling either. The javadoc of start method
says
Starts the trainer for collecting samples.
We are not doing that anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
