yifan-c commented on code in PR #4599:
URL: https://github.com/apache/cassandra/pull/4599#discussion_r2762585138
##########
src/java/org/apache/cassandra/db/compression/ZstdDictionaryTrainer.java:
##########
@@ -304,9 +283,9 @@ public TrainingState getTrainingState()
}
@Override
- public boolean start(boolean manualTraining,
CompressionDictionaryTrainingConfig trainingConfig)
+ public boolean start(CompressionDictionaryTrainingConfig trainingConfig)
{
- if (closed || !(manualTraining || shouldAutoStartTraining()))
+ if (closed)
return false;
try
Review Comment:
Agreed on remove the log message. Given that, the training is manual, the
log message to indicate the start of the process is less useful.
##########
src/java/org/apache/cassandra/db/compression/ZstdDictionaryTrainer.java:
##########
@@ -304,9 +283,9 @@ public TrainingState getTrainingState()
}
@Override
- public boolean start(boolean manualTraining,
CompressionDictionaryTrainingConfig trainingConfig)
+ public boolean start(CompressionDictionaryTrainingConfig trainingConfig)
{
- if (closed || !(manualTraining || shouldAutoStartTraining()))
+ if (closed)
return false;
try
Review Comment:
Agreed on the log message removal. Given that, the training is manual, the
log message to indicate the start of the process is less useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
