aweisberg commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3423037292
##########
src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java:
##########
@@ -287,9 +296,12 @@ protected final void logFailureOrTimeoutToIdealCLDelegate()
}
}
- public final void expired()
+ public final void expired(InetAddressAndPort from)
{
+ plan.responses().onFailure(from, RequestFailureReason.NODE_DOWN);
Review Comment:
RequestFailureReason is unsused here. It also looks like this doesn't call
`onFailure` and this is maybe a pre-existing issue? This means that
`failureReasonByEndpoint` isn't populated.
It's very odd because it looks like `expired()` didn't cause signaling
before this change which is perplexing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
