aweisberg commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3423584161
##########
src/java/org/apache/cassandra/service/reads/ReadCallback.java:
##########
@@ -231,14 +227,15 @@ public void onResponse(Message<ReadResponse> message)
}
resolver.preprocess(message);
replicaPlan().collectSuccess(message.from());
+ plan.responses().onResponse(from);
Review Comment:
It is kind of messy that we in some places collect failure/success
information outside the response trackers, but then do the counts in the
response trackers. These should really be unified more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
