aweisberg commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3423297785
##########
src/java/org/apache/cassandra/service/WriteResponseHandler.java:
##########
@@ -69,17 +65,19 @@ public void onResponse(Message<T> m)
if (WriteWarningContext.isSupported(params.keySet()))
getWarningContext().updateCounters(params);
- replicaPlan.collectSuccess(from);
- if (responsesUpdater.decrementAndGet(this) == 0)
+ replicaPlan().collectSuccess(from);
+
+ plan.responses().onResponse(from);
+
+ if (plan.responses().isComplete())
Review Comment:
This is not atomic and could result in a double signal. This problem is
pervasive throughout this patch in how signal is invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
