aweisberg commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3423128770
##########
src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java:
##########
@@ -378,14 +395,16 @@ public void onFailure(InetAddressAndPort from,
RequestFailure failure)
}
failureReasonByEndpoint.put(from, failure.reason);
+ plan.responses().onFailure(from, failure.reason);
+
logFailureOrTimeoutToIdealCLDelegate();
- if (blockFor() + n > candidateReplicaCount())
+ if (plan.responses().isComplete() && !plan.responses().isSuccessful())
Review Comment:
Seems like this should be a single combined method that simply implements
whatever this is checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
