belliottsmith commented on code in PR #4936:
URL: https://github.com/apache/cassandra/pull/4936#discussion_r3594715652
##########
src/java/org/apache/cassandra/transport/Message.java:
##########
@@ -430,6 +442,7 @@ public Envelope encode(ProtocolVersion version)
if (responseVersion.isBeta())
flags = Flag.add(flags, Flag.USE_BETA);
+ assert getStreamId() != UNSET_STREAM_ID : "Response streamId was
never set: " + this;
Review Comment:
This should not be an assertion, it should be a normal check and throw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
