frankgh commented on code in PR #4936: URL: https://github.com/apache/cassandra/pull/4936#discussion_r3616311136
########## src/java/org/apache/cassandra/transport/Message.java: ########## Review Comment: Since this is orthogonal to the problem that we are solving here I think it deserves its own JIRA ticket. > seems there is a risk of leaving orphaned trace sessions if there is an unexpected exception from execute I don't see how this is possible, the finally block below applies for all exception types. Which means that the tracing will always call `stopSession` when we are tracing. I think there might be a case where rewrapping the exception does not propagate the tracing id. So I think it's worth looking into it, but it would be out of scope for this ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
