tejalchak commented on code in PR #4936:
URL: https://github.com/apache/cassandra/pull/4936#discussion_r3616409207
##########
src/java/org/apache/cassandra/transport/Message.java:
##########
Review Comment:
Wait traceId is very similar to streamId wrt exception handling path being
different from normal
```
try {
response = execute(queryState, requestTime, shouldTrace); // ← THROWS
here
}
finally {
if (shouldTrace)
Tracing.instance.stopSession(); // stops BUT did not
}
...
if (isTraceable() && isTracingRequested())
response.setTracingId(tracingSessionId); // SKIPPED on throw outside
try/finally
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
