tejalchak commented on code in PR #4936: URL: https://github.com/apache/cassandra/pull/4936#discussion_r3611742269
########## src/java/org/apache/cassandra/transport/Message.java: ########## Review Comment: It seems there is a risk of leaving orphaned trace sessions if there is an unexpected exception from execute. I wonder if moving the traceId to where the decoration/stamping occurs for all cases (toFlushItem or decorateResponse) would make observability exception path get robust as well. Let me know your thoughts (could be fixed in a follow on tkt or here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
