toutpt wrote: Hi,
Nitpicking allowed. :) I haven't look inside the code itself, but rather to the layout/structure. - I would put Browserviews in a browser-folder. - Having javascript-files in the main directory seems a bit odd to me. Normally I would expect those in browser/resources. - I don't expect a templates-folder, but rather browser/templates - I don't expect a link-folder, but rather an adapters-folder - In docs/HISTORY.txt there is no (unreleased) section for new changes. Take a look at zest.releaser. It seems you are not using it. It's extremely handy. - Personnally I've stopped using docs/HISTORY.txt and use CHANGES.txt instead, I see the same evolution in many other packages. - In setup.py you're not yet using z3c.autoinclude cfr. http://pypi.python.org/pypi/z3c.autoinclude - In profiles you don't have an uninstall-profile. I would create one to uninstall at least the css/js-files and the skins. - When using a single skins-layer I would tend use the underscored package-name, e.g. collective_gallery - You have tests-folder and testing.py. I wouldn't expect both. - a locales-folder without an en-subfolder always seems incomplete to me, even though the po-file doesn't need translation because en is the default language. -- Greets, WouterVH _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
