Wouter Vanden Hove wrote: > toutpt wrote: > > Hi, > > Nitpicking allowed. :) > > I haven't look inside the code itself, but rather to the layout/structure. > > - I would put Browserviews in a browser-folder.
There's a lot to be said for using paster to create your initial folder structures. > > - Having javascript-files in the main directory seems a bit odd to me. > Normally I would expect those in browser/resources. I haven't noticed any consistency between products in this regard, but would agree having a browser/resources would be a Good Thing. > > - I don't expect a templates-folder, but rather browser/templates > > - I don't expect a link-folder, but rather an adapters-folder I've never seen a product with an "adapters" folder, but it is probably more useful for future maintainers. > > - In docs/HISTORY.txt there is no (unreleased) section for new changes. > Take a look at zest.releaser. It seems you are not using it. > It's extremely handy. Haven't used it, but it sounds like something I've been doing manually, so I'll have to look at zest.releaser, thanks. > > - Personnally I've stopped using docs/HISTORY.txt and use CHANGES.txt > instead, I see the same evolution in many other packages. And I couldn't decide which was "correct", so symlink one to the other. > - In setup.py you're not yet using z3c.autoinclude > cfr. http://pypi.python.org/pypi/z3c.autoinclude Something else I'll have to look at. > - In profiles you don't have an uninstall-profile. > I would create one to uninstall at least the css/js-files and the skins. Something I've complained about before - there isn't nearly enough documentation about Generic Setup. I wouldn't have a clue how to make my products uninstall css & js. -- derek _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
