Hi Jean-Michel, Op 25-05-10 10:44, toutpt schreef: > Wouter Vanden Hove-2 wrote: >> >> - In docs/HISTORY.txt there is no (unreleased) section for new changes. >> Take a look at zest.releaser. It seems you are not using it. >> It's extremely handy. >> > Oups ... I definitly need to use a releaser.
Yes, warmly recommended by one of its authors. ;-) > Wouter Vanden Hove-2 wrote: >> >> - In profiles you don't have an uninstall-profile. >> I would create one to uninstall at least the css/js-files and the skins. >> > Yes it is needed but the last time I have tried to do this the uninstall > profile was just seen as a default to install things and not use by the > quick installer. Do I really need to add also an Extensions/Install.py > oldish things ? I have not written an uninstall profile myself yet (I probably should), but I saw one in collective.blogging, including the accompanying Extensions/Install.py that is indeed necessary. There is nothing in GenericSetup that registers a profile A as the uninstall/undo profile of profile B. If you use the portal_quickinstaller I would think the CSS and javascript get cleaned up automatically even without a custom uninstaller, because portal_quickinstaller takes some notes during the install. I am not completely sure if the same is true in Plone 3.3 when using the Add/Remove Products control panel in the Site Setup. If you call one profile 'default' and the other profile 'uninstall' then the quick installer will sort these alphabetically and pick the first one as the profile to apply when installing your package. So do not call your uninstall profile 'cleanup' as then it will get picked as the main install profile. Also, please use only lowercase letters, because if you have profiles 'default' and 'Uninstall' I don't know which one will get picked as the first; and there may even be differences in sorting between Operating Systems. > Wouter Vanden Hove-2 wrote: >> >> - You have tests-folder and testing.py. I wouldn't expect both. >> > I have try to use collective.testcaselayer based on some eggs like > Products.ImageEditor. I'm not used to this one, may be I have not used it > properly. I would be more surprised and alarmed at having a tests folder and a tests.py file; I have seen this... > Wouter Vanden Hove-2 wrote: >> >> - a locales-folder without an en-subfolder always seems incomplete to me, >> even though the po-file doesn't need translation because en is the >> default >> language. >> > Oh really ? At least in some Plone 3 versions (maybe all, maybe in Plone 4 too, but Hanno may have fixed something there), when you do not have an 'en' locale and your site has English as default language and French as allowed second language, and someone comes along with a browser that accepts first English and then French, the French translations will show up instead of the default English. The idea is that Plone thinks like this: browser accepts English and French, we have only a French translations, so we serve French. If a browser that only wants Dutch (with perhaps English accepted too) comes along, Plone thinks: browser wants Dutch, we do not have it, so we do not translate (which will usually mean: fall back to the default English). Basically, if you add an English po file and do not translate anything in there, this is a signal to Plone that the strings in your package are English. If you sprinkle French words in your templates and python files, you should add an untranslated French locale. -- Maurits van Rees Programmer, Zest Software _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
